[webkit-reviews] review granted: [Bug 46768] Paint the plug-in backing store into the WebProcess backing store : [Attachment 69138] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 46768: Paint the plug-in backing store into the WebProcess backing store
https://bugs.webkit.org/show_bug.cgi?id=46768

Attachment 69138: Patch
https://bugs.webkit.org/attachment.cgi?id=69138&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69138&action=review

> WebKit2/WebKit2Prefix.h:47
>  // FIXME: Enable once this works well enough.
> -#define ENABLE_PLUGIN_PROCESS 0
> +#define ENABLE_PLUGIN_PROCESS 1

Was this intentional?

> WebKit2/WebProcess/Plugins/PluginProxy.cpp:115
> +    CGContextRef platformContext = graphicsContext->platformContext();
> +    CGContextSaveGState(platformContext);

This should be removed. You never even restore the GState.