[webkit-reviews] review granted: [Bug 41269] add python keyring support to webkit-patch : [Attachment 69118] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 41269: add python keyring support to webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=41269

Attachment 69118: Patch
https://bugs.webkit.org/attachment.cgi?id=69118&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69118&action=review

OK.  We should consider autoinstalling keyring in a later patch.

Thanks again!

> WebKitTools/Scripts/webkitpy/common/net/credentials.py:53
> +		    keyring=keyring):

I'm told that foo=None followed by a self._foo = foo or default_foo  is better
here, since keyring will be a singleton and thus shared between multiple
instances of the object.

In this case, I think it's OK.	But for example foo=[] would be bad. :)  You
wouldn't actually end up with a new [] for each object.