[webkit-reviews] review denied: [Bug 46493] [chromium] Add mipmap support for ImageLayerChromium : [Attachment 69101] Patch

[bugzilla-daemon at webkit.org]

Vangelis Kokkevis <vangelis at chromium.org> has denied W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 46493: [chromium] Add mipmap support for ImageLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=46493

Attachment 69101: Patch
https://bugs.webkit.org/attachment.cgi?id=69101&action=review

------- Additional Comments from Vangelis Kokkevis <vangelis at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69101&action=review

> WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:281
> +	       GLC(context,
context->generateMipmap(GraphicsContext3D::TEXTURE_2D));

You'll need to also call generateMipmap in the "else" clause as well, if the
conditions are met. I suggest doing something like:

bool doMipmap =  generateMipmap &&
(layerRenderer()->contentLayerSharedValues()->npotSupported() ||
(isPowerOfTwo(updateRect.width()) && isPowerOfTwo(updateRect.height())))

outside the if statement and the in the "if" part do:

if (doMipmap)
  set filter modes


and outside the if statement
if (doMipmap)
  generateMipmap