[webkit-reviews] review denied: [Bug 46679] Delete and forward delete shouldn't start autocorrection panel timer. : [Attachment 69099] Proposed patch (v2)

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied jpu at apple.com's request for review:
Bug 46679: Delete and forward delete shouldn't start autocorrection panel
timer.
https://bugs.webkit.org/show_bug.cgi?id=46679

Attachment 69099: Proposed patch (v2)
https://bugs.webkit.org/attachment.cgi?id=69099&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=69099&action=review

> WebCore/editing/TypingCommand.cpp:321
> +#if PLATFORM(MAC) && !defined(BUILDING_ON_TIGER) &&
!defined(BUILDING_ON_LEOPARD)
>  void TypingCommand::typingAddedToOpenCommand(ETypingCommand
commandTypeForAddedTyping)
> +#else
> +void TypingCommand::typingAddedToOpenCommand(ETypingCommand)
> +#endif

The complaint was about markMisspellingsAfterTyping() having an unused (in some
configurations) parameter, not about this method, so I’m not sure why you’re
changing this one. I think it will break all builds.

The way to fix the warning about markMisspellingsAfterTyping() is to add
UNUSED_PARAM(commandType)
for the configurations that don’t use commandType.

You’ll need to make sure that you’re including <wtf/UnusedParam.h>—but I think
you have it by way of including Editor.h.