[webkit-reviews] review requested: [Bug 46743] Event dispatching in XMLHttpRequestProgressEventThrottle should go through XMLHttpRequestProgressEventThrottle::dispatchEvent : [Attachment 69081] [PATCH] Refactor XMLHttpRequestProgressEventThrottle event dispatching

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 28 12:03:37 PDT 2010


Anton D'Auria <adauria at apple.com> has asked  for review:
Bug 46743: Event dispatching in XMLHttpRequestProgressEventThrottle should go
through XMLHttpRequestProgressEventThrottle::dispatchEvent
https://bugs.webkit.org/show_bug.cgi?id=46743

Attachment 69081: [PATCH] Refactor XMLHttpRequestProgressEventThrottle event
dispatching
https://bugs.webkit.org/attachment.cgi?id=69081&action=review

------- Additional Comments from Anton D'Auria <adauria at apple.com>
In preparation for platform-specific queuing of XMLHttpRequest events, this
patch changes all calls to m_target->dispatchEvent to
XMLHttpRequestProgressEventThrottle::dispatchEvent. Currently, we queue up only
a progress event on suspend() if we have throttled progress events. We should
be able to queue all XHR events that  can be generated after suspend(), if the
platform network layer continues to receive data. XMLHttpRequest uses
XMLHttpRequestProgressEventThrottle to dispatch only download events, so this
doesn't change behavior of upload events, which aren't throttled or queued.


More information about the webkit-reviews mailing list