[webkit-reviews] review granted: [Bug 11154] Soft hyphenation and the clipboard : [Attachment 69076] Improve the handling of soft hyphens in Copy and Find operations

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 11154: Soft hyphenation and the clipboard
https://bugs.webkit.org/show_bug.cgi?id=11154

Attachment 69076: Improve the handling of soft hyphens in Copy and Find
operations
https://bugs.webkit.org/attachment.cgi?id=69076&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69076&action=review

Would be nice to add some test cases for things Alexey mentioned (double
clicking to select a word, granularity functions) at some point.

> WebCore/ChangeLog:34
> +	   (WebCore::foldQuoteMarkOrSoftHyphen): Renamed foldQuoteMark() to
this and added folding of
> +	   soft hpyhen to 0.

Tpyo.

> WebCore/editing/TextIterator.cpp:1549
> +	   case softHyphen:
> +	       return 0;

I think we might need a comment, not just change log, about why folding a soft
hyphen to a U+0000 is helpful. It’s much more obvious why folding a quote mark
to the ASCII equivalent is helpful, which is why that has no “why” comment.