[webkit-reviews] review granted: [Bug 46734] Improve plug-in process lifecycle handling : [Attachment 69066] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 28 10:26:53 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 46734: Improve plug-in process lifecycle handling
https://bugs.webkit.org/show_bug.cgi?id=46734

Attachment 69066: Patch
https://bugs.webkit.org/attachment.cgi?id=69066&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69066&action=review

> WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp:83
> +    for (HashMap<uint64_t, PluginProxy*>::const_iterator it =
m_plugins.begin(), end = m_plugins.end(); it != end; ++it) {
> +	   PluginProxy* pluginProxy = it->second;
> +
> +	   pluginProxy->pluginProcessCrashed();
> +    }

You could iterate over just the values.


More information about the webkit-reviews mailing list