[webkit-reviews] review granted: [Bug 46660] Need API to tell a WebKit2 client application that a key event was not handled : [Attachment 69065] Tell the UI client when a key event is not handled

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 46660: Need API to tell a WebKit2 client application that a key event was
not handled
https://bugs.webkit.org/show_bug.cgi?id=46660

Attachment 69065: Tell the UI client when a key event is not handled
https://bugs.webkit.org/attachment.cgi?id=69065&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69065&action=review

> WebKit2/UIProcess/WebPageProxy.cpp:711
>	       uint32_t type;
>	       if (!arguments->decode(type))
>		   return;
> -	       didReceiveEvent((WebEvent::Type)type);
> +	       bool handled;
> +	       if (!arguments->decode(handled))
> +		   return;
> +	       didReceiveEvent((WebEvent::Type)type, handled);
>	       break;
>	   }

We usually do this in one decode step using CoreIPC::Out().