[webkit-reviews] review granted: [Bug 34716] audio engine: audio output classes : [Attachment 67594] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 28 09:53:53 PDT 2010


Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 34716: audio engine: audio output classes
https://bugs.webkit.org/show_bug.cgi?id=34716

Attachment 67594: Patch
https://bugs.webkit.org/attachment.cgi?id=67594&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=67594&action=review

Looks good.

> WebCore/platform/audio/mac/AudioDestinationMac.cpp:40
> +const int kBufferSize = 128;

FYI, naming convention for these constants is "BufferSize".


More information about the webkit-reviews mailing list