[webkit-reviews] review granted: [Bug 46728] Add PluginControllerProxy class : [Attachment 69059] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 46728: Add PluginControllerProxy class
https://bugs.webkit.org/show_bug.cgi?id=46728

Attachment 69059: Patch
https://bugs.webkit.org/attachment.cgi?id=69059&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69059&action=review

> WebKit2/ChangeLog:17
> +	   (WebKit::WebProcessConnection::addPluginControllerProxy
> +	   Add the plug-in controller proxy to the map.

Missing the trailing ): here.

> WebKit2/PluginProcess/PluginControllerProxy.h:65
> +    // We use a weak reference to the web process connection because the
WebProcessConnection has a strong
> +    // reference to the PluginControllerProxy objects.
> +    WebProcessConnection* m_connection;

Since PluginControllerProxy is ref-counted, it's hard to guarantee that it
doesn't outlive its WebProcessConnection. Maybe we should have a way to tell
PluginControllerProxy that its WebProcessConnection has been destroyed.

> WebKit2/PluginProcess/WebProcessConnection.cpp:52
> +void WebProcessConnection::addPluginControllerProxy(PluginControllerProxy*
pluginController)

This should take a PassRefPtr.