[webkit-reviews] review granted: [Bug 46710] [Chromium] Linking error due to wrong guard in WebIDBTransaction.h : [Attachment 69034] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Andrei Popescu
<andreip at google.com>'s request for review:
Bug 46710: [Chromium] Linking error due to wrong guard in WebIDBTransaction.h
https://bugs.webkit.org/show_bug.cgi?id=46710

Attachment 69034: Patch
https://bugs.webkit.org/attachment.cgi?id=69034&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69034&action=review

r=me

> WebKit/chromium/public/WebIDBTransaction.h:65
> +	   // FIXME: this is never called in the renderer. Find a cleaner
solution.

Comments that apply to the whole function really seem like they should go right
above the function not in them.  Is there other precedent for something like
this?  If not, can you please stop doing this?

Also, try not to make the comments Chromium architecture specific.  Maybe just
say that this is only meant to be called from within WebCore?