[webkit-reviews] review denied: [Bug 46531] Autocorrection panel is shown at incorrect location when WebView is scrolled. : [Attachment 68945] Proposed patch (v1)

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied jpu at apple.com's request for review:
Bug 46531: Autocorrection panel is shown at incorrect location when WebView is
scrolled.
https://bugs.webkit.org/show_bug.cgi?id=46531

Attachment 68945: Proposed patch (v1)
https://bugs.webkit.org/attachment.cgi?id=68945&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=68945&action=review

> WebCore/editing/Editor.cpp:2719
> +			   RefPtr<ClientRect> clientRect =
rangeToReplace->getBoundingClientRect();

I don’t think getBoundingClientRect() is appropriate here. It is high-level DOM
API which calls updateLayoutIgnorePendingStylesheets() and creates a DOM object
(ClientRect) which you don’t need for the client interface. I think you should
call getBorderAndTextQuads() directly to get a vector of quads in view
coordinates.