[webkit-reviews] review requested: [Bug 45423] [Gtk] Port tiled backing store : [Attachment 69014] Updated version: Takes all the comments into account

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 27 20:41:49 PDT 2010


Julien Chaffraix <jchaffraix at webkit.org> has asked  for review:
Bug 45423: [Gtk] Port tiled backing store
https://bugs.webkit.org/show_bug.cgi?id=45423

Attachment 69014: Updated version: Takes all the comments into account
https://bugs.webkit.org/attachment.cgi?id=69014&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
Just a caveat, I say I would move the ChromeClientGtk method into the webview
but actually visibleRectForTiledBackingStore is a virtual function expected to
be implemented by ChromeClient ports. It’s a one liner so not sure how it can
be split. Also a call from ChromeClient -> webview api layer doesn’t seem
right.


More information about the webkit-reviews mailing list