[webkit-reviews] review granted: [Bug 46336] Make Document::nodesFromRect more flexible : [Attachment 68873] patch v3.2 - actual fixed patch.

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 46336: Make Document::nodesFromRect more flexible
https://bugs.webkit.org/show_bug.cgi?id=46336

Attachment 68873: patch v3.2 - actual fixed patch.
https://bugs.webkit.org/attachment.cgi?id=68873&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68873&action=review

LGTM

> WebCore/dom/Document.cpp:1071
> +    else if
(!frameView->visibleContentRect().intersects(HitTestResult::rectFromPoint(point
, topPadding, rightPadding, bottomPadding, leftPadding)))

rectForPoint?

> WebCore/dom/Document.cpp:1078
> +    if (!topPadding && !rightPadding && !bottomPadding && !leftPadding) {

are all these unsigned?

> WebCore/dom/Document.h:326
> +    PassRefPtr<NodeList> nodesFromRect(int centerX,
> +					  int centerY,
> +					  unsigned topPadding,
> +					  unsigned rightPadding,
> +					  unsigned bottomPadding,
> +					  unsigned leftPadding,
> +					  bool ignoreClipping) const;

we usually put all these on one line, I even think the style guide says
somethiong about that