[webkit-reviews] review granted: [Bug 46233] Add HRTFDatabase files : [Attachment 68959] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 27 16:53:54 PDT 2010
James Robinson <jamesr at chromium.org> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 46233: Add HRTFDatabase files
https://bugs.webkit.org/show_bug.cgi?id=46233
Attachment 68959: Patch
https://bugs.webkit.org/attachment.cgi?id=68959&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68959&action=review
Looks good. Two nits, feel free to fix while landing or upload a new patch.
> WebCore/platform/audio/HRTFDatabase.cpp:78
> + double x = double(jj) / double(InterpolationFactor);
nit: static_cast<double>()
> WebCore/platform/audio/HRTFDatabase.h:62
> + HRTFDatabase(double sampleRate);
nit: this needs explicit
More information about the webkit-reviews
mailing list