[webkit-reviews] review granted: [Bug 46524] Bridge all FileSystem operations on Workers to the MainThread : [Attachment 68811] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 46524: Bridge all FileSystem operations on Workers to the MainThread
https://bugs.webkit.org/show_bug.cgi?id=46524

Attachment 68811: Patch
https://bugs.webkit.org/attachment.cgi?id=68811&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68811&action=review

Please consider doing Adam's comment and mine.

Thanks!

> WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp:150
> +PassRefPtr<WorkerFileSystemCallbacksBridge>
WorkerFileSystemCallbacksBridge::createForOpenFileSystem(WebWorkerBase* worker,
ScriptExecutionContext* workerContext, WebFileSystemCallbacks* callbacks,
WebCommonWorkerClient* commonClient, WebFileSystem::Type type, long long size,
const String& mode)

I wouldn't bother making these be "createFor" methods and returning a class
that no one ever uses.

Consider just returning void and calling the method:
"WorkerFileSystemCallbacksBridge::openFileSystem".