[webkit-reviews] review granted: [Bug 45069] VideoLayerChromium uses GPU YUV to RGB color conversion : [Attachment 68985] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Victoria Kirst
<vrk at google.com>'s request for review:
Bug 45069: VideoLayerChromium uses GPU YUV to RGB color conversion
https://bugs.webkit.org/show_bug.cgi?id=45069

Attachment 68985: Patch
https://bugs.webkit.org/attachment.cgi?id=68985&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68985&action=review

R=me

> WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:66
> +    , m_yuvWidthScaleFactorLocation(0)
> +    , m_rgbaShaderMatrixLocation(0)
> +    , m_rgbaWidthScaleFactorLocation(0)
> +    , m_ccMatrixLocation(0)
> +    , m_yTextureLocation(0)
> +    , m_uTextureLocation(0)
> +    , m_vTextureLocation(0)
> +    , m_rgbaTextureLocation(0)
> +    , m_yuvAlphaLocation(0)
> +    , m_rgbaAlphaLocation(0)

nit: should these initialize to -1?