[webkit-reviews] review denied: [Bug 46665] Patch RenderView's layout and computeLogicalWidth/Height methods to be block-flow-aware. : [Attachment 68978] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 46665: Patch RenderView's layout and computeLogicalWidth/Height methods to
be block-flow-aware.
https://bugs.webkit.org/show_bug.cgi?id=46665

Attachment 68978: Patch
https://bugs.webkit.org/attachment.cgi?id=68978&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68978&action=review

> WebCore/rendering/RenderBox.cpp:1737
> -	   else  {
> -	       if (style()->isVerticalBlockFlow())
> -		   visHeight = view()->viewHeight();
> -	       else
> -		   visHeight = view()->viewWidth();
> -	   }
> +	   else
> +	       visHeight = view()->viewLogicalHeight();

I don't think this will end up using the correct style().