[webkit-reviews] review granted: [Bug 45571] Add AudioNode files : [Attachment 68282] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 27 15:39:10 PDT 2010


Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 45571: Add AudioNode files
https://bugs.webkit.org/show_bug.cgi?id=45571

Attachment 68282: Patch
https://bugs.webkit.org/attachment.cgi?id=68282&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
We've discussed both this patch and that for AudioContext extensively offline
and at this point I think this looks very good. One comment for the record: the
reason that the atomic increments in AudioNode::ref() aren't guarded by the
graph lock is covered by the FIXME in that method; this would only be necessary
if waking up of a note which has already played were supported, which currently
it is not.


More information about the webkit-reviews mailing list