[webkit-reviews] review requested: [Bug 46139] [chromium] LayerChromium and its derived types should use virtual destructors : [Attachment 68973] Proposed patch - Does proper ref counting for the compositor

[bugzilla-daemon at webkit.org]

Vangelis Kokkevis <vangelis at chromium.org> has asked  for review:
Bug 46139: [chromium] LayerChromium and its derived types should use virtual
destructors
https://bugs.webkit.org/show_bug.cgi?id=46139

Attachment 68973: Proposed patch - Does proper ref counting for the compositor
https://bugs.webkit.org/attachment.cgi?id=68973&action=review

------- Additional Comments from Vangelis Kokkevis <vangelis at chromium.org>
Corrected the reason why the previous patch was causing crashes which was that
LayerChromium destructors could end up getting called after the layer
compositor and its associated gl context were destroyed. This patch makes the
LayerRendererChromium a ref counted class and the LayerChromium's used by it
are now holding a reference to LayerRendererChromium they are used with. This
ensures that the gl context used by the layers will outlive the layers
themselves.