[webkit-reviews] review granted: [Bug 46654] Add support for autogenerating synchronous message handlers : [Attachment 68964] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 46654: Add support for autogenerating synchronous message handlers
https://bugs.webkit.org/show_bug.cgi?id=46654

Attachment 68964: Patch
https://bugs.webkit.org/attachment.cgi?id=68964&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68964&action=review

> WebKit2/Scripts/webkit2/messages.py:384
> +    if async_messages:
> +	   result.append('void %s::didReceive%sMessage(CoreIPC::Connection*,
CoreIPC::MessageID messageID, CoreIPC::ArgumentDecoder* arguments)\n' %
(receiver.name, receiver.name))
> +	   result.append('{\n')
> +	   result.append('    switch (messageID.get<Messages::%s::Kind>()) {\n'
% receiver.name)
> +	   result += [async_case_statement(receiver, message) for message in
async_messages]
> +	   result.append('    default:\n')
> +	   result.append('	  break;\n')
> +	   result.append('    }\n\n')
> +	   result.append('    ASSERT_NOT_REACHED();\n')
> +	   result.append('}\n')
> +
> +    if sync_messages:
> +	   result.append('\n')
> +	   result.append('CoreIPC::SyncReplyMode
%s::didReceiveSync%sMessage(CoreIPC::Connection*, CoreIPC::MessageID messageID,
CoreIPC::ArgumentDecoder* arguments, CoreIPC::ArgumentEncoder* reply)\n' %
(receiver.name, receiver.name))
> +	   result.append('{\n')
> +	   result.append('    switch (messageID.get<Messages::%s::Kind>()) {\n'
% receiver.name)
> +	   result += [sync_case_statement(receiver, message) for message in
sync_messages]
> +	   result.append('    default:\n')
> +	   result.append('	  break;\n')
> +	   result.append('    }\n\n')
> +	   result.append('    ASSERT_NOT_REACHED();\n')
> +	   result.append('    return CoreIPC::AutomaticReply;\n')
> +	   result.append('}\n')

It would be nice not to duplicate so much code.