[webkit-reviews] review granted: [Bug 46633] WebKit2: allow debug opt-out from sandbox via default : [Attachment 68933] Allow disabling WebKit2 sandbox on Mac

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has granted Ivan Krstić <ike at apple.com>'s
request for review:
Bug 46633: WebKit2: allow debug opt-out from sandbox via default
https://bugs.webkit.org/show_bug.cgi?id=46633

Attachment 68933: Allow disabling WebKit2 sandbox on Mac
https://bugs.webkit.org/attachment.cgi?id=68933&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68933&action=review

> WebProcess/mac/WebProcessMainMac.mm:75
> +    } else {
> +	   fprintf(stderr, "WebProcess: bypassing sandbox due to
com.apple.WebProcess.DisableSandbox default; behavior will differ from
production builds\n");
>      }

The braces around this “else” are unnecessary and should be removed.  I think
it would be preferable to use NSLog here rather than printf.  I will make those
changes when landing this patch.