[webkit-reviews] review granted: [Bug 46509] Add operator == for AtomicString and Vector<Uchar> : [Attachment 68937] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 27 11:47:34 PDT 2010
Darin Adler <darin at apple.com> has granted Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 46509: Add operator == for AtomicString and Vector<Uchar>
https://bugs.webkit.org/show_bug.cgi?id=46509
Attachment 68937: Patch
https://bugs.webkit.org/attachment.cgi?id=68937&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68937&action=review
> JavaScriptCore/wtf/text/AtomicString.cpp:158
> }
> +bool operator==(const AtomicString& a, const Vector<UChar>& b)
There should be a blank line there.
We could use the names "string" and "vector" instead of "a" and "b" here.
More information about the webkit-reviews
mailing list