[webkit-reviews] review granted: [Bug 46634] webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console : [Attachment 68935] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 46634: webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list
spams the console
https://bugs.webkit.org/show_bug.cgi?id=46634

Attachment 68935: Patch
https://bugs.webkit.org/attachment.cgi?id=68935&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems OK.  We could care about the output.  assert_outputs will return the
value of the function it calls.  The comment should probably say "Other tests
cover output, this test only checks parsing behavior" or similar.

I guess I should implement __enter__ and __exit__ for OutputCapture so we can
use it with "with"