[webkit-reviews] review granted: [Bug 37880] [Qt] Patch for checking content types supported by the QWebPage... : [Attachment 65418] Function for checking content-type supported by QWebPage III...

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Dawit A.
<adawit at kde.org>'s request for review:
Bug 37880: [Qt] Patch for checking content types supported by the QWebPage...
https://bugs.webkit.org/show_bug.cgi?id=37880

Attachment 65418: Function for checking content-type supported by QWebPage
III...
https://bugs.webkit.org/attachment.cgi?id=65418&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=65418&action=review

How is this affecting performance?. LGTM.

> WebKit/qt/Api/qwebpage.cpp:2174
> +static void extractContentTypeFromPluginList(const Vector<PluginPackage*>&
plugins, QStringList* list)

PluginList? It seems to be a vector.

> WebKit/qt/Api/qwebpage.cpp:2188
> + *  \since 4.8

I don't know if this is right, since this might be part of QtWebKit2.1, but
well...

> WebKit/qt/Api/qwebpage.cpp:2213
> +	 return true;

indentation seems wrong here

> WebKit/qt/Api/qwebpage.cpp:2216
> +	 return true;

identation issue

> WebKit/qt/Api/qwebpage.cpp:2218
> +    if (d->page->settings() && d->page->settings()->arePluginsEnabled() &&

&& should always be at the start of a line according to the style guide

> WebKit/qt/Api/qwebpage.cpp:2220
> +	 return true;

indentation issue