[webkit-reviews] review denied: [Bug 41571] [Qt] Fix http/tests/loading/redirect-methods.html : [Attachment 66668] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 27 10:54:25 PDT 2010


Adam Barth <abarth at webkit.org> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 41571: [Qt] Fix http/tests/loading/redirect-methods.html
https://bugs.webkit.org/show_bug.cgi?id=41571

Attachment 66668: Patch
https://bugs.webkit.org/attachment.cgi?id=66668&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I don't think this is quite right.  You shouldn't need
m_receivedPermanentRedirect.  What happens is that the first 301 (or whatever)
changes the method to GET.  By the time you get to the 307, you shouldn't have
a POST method anymore.	307 should always preserve the method of the request
that received the 307.	That's the whole point of 307 existing.


More information about the webkit-reviews mailing list