[webkit-reviews] review granted: [Bug 46630] [GTK] use ENABLE(GLIB_SUPPORT) : [Attachment 68925] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 27 10:37:14 PDT 2010


Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 46630: [GTK] use ENABLE(GLIB_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=46630

Attachment 68925: updated patch
https://bugs.webkit.org/attachment.cgi?id=68925&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
Great. As I mentioned to Philippe via Jabber, we're probably going to remove
the GDK-specific stuff from FontPlatformDataFreeType soon, so we can avoid the
issue of adding a GDK-specific flag for now. I think I'd still like to see this
transformed into either USE(GLIB) or PLATFORM(GLIB) in a later patch.


More information about the webkit-reviews mailing list