[webkit-reviews] review granted: [Bug 46624] Web Inspector: implement pausing on event listeners (back-end part) : [Attachment 68917] Proposed patch.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 46624: Web Inspector: implement pausing on event listeners (back-end part)
https://bugs.webkit.org/show_bug.cgi?id=46624

Attachment 68917: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=68917&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68917&action=review

> WebCore/bindings/js/ScriptDebugServer.cpp:@
>  void ScriptDebugServer::pause()

Lets be verbose here and call it "setPauseOnNextStatement".

> WebCore/dom/Node.cpp:2619
> +    InspectorController::instrumentWillDispatchEvent(document(), *event);

Could you move timeline agent call below into instrumentWillDispatch?

> WebCore/dom/Node.cpp:2712
> +    InspectorController::instrumentDidDispatchEvent(document());

ditto