[webkit-reviews] review requested: [Bug 45443] [GTK] Support for viewport meta tag : [Attachment 68913] Proposed Patch2

[bugzilla-daemon at webkit.org]

Joone Hur <joone at kldp.org> has asked  for review:
Bug 45443: [GTK] Support for viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=45443

Attachment 68913: Proposed Patch2
https://bugs.webkit.org/attachment.cgi?id=68913&action=review

------- Additional Comments from Joone Hur <joone at kldp.org>
During resolving this issue, Opera viewport CSS properties spec. applied to the
mainline.
https://bugs.webkit.org/show_bug.cgi?id=44201
Until then, we just had got the viewport meta tag information, but this patch
also allows to get the calculated viewport configuration from WebCore.
It means that we can get the available viewport size, initial/maximum/minimum
scale value through the device width/height and desktop width.

In addition, this patch supports viewport test cases (fast/viewport) except
viewport-45.html.
It fails as follows,

--- /tmp/layout-test-results/fast/viewport/viewport-45-expected.txt   
2010-09-27 16:56:08.000000000 +0900
+++ /tmp/layout-test-results/fast/viewport/viewport-45-actual.txt    2010-09-27
16:56:08.000000000 +0900
@@ -1,2 +1,2 @@
-viewport size 3200x3520 scale 0.100000 with limits [0.100000, 0.100000]
+viewport size 3199x3519 scale 0.100000 with limits [0.100000, 0.100000]

Therefore, I let DRT test skips this test case for WebKitGtk.