[webkit-reviews] review requested: [Bug 44761] [Qt] tst_QWebView::focusInputTypes() fails on MeeGo Handset with WebKit 2.1 : [Attachment 68911] Improve the test further

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 27 07:53:20 PDT 2010


Benjamin Poulain <benjamin.poulain at nokia.com> has asked  for review:
Bug 44761: [Qt] tst_QWebView::focusInputTypes() fails on MeeGo Handset with
WebKit 2.1
https://bugs.webkit.org/show_bug.cgi?id=44761

Attachment 68911: Improve the test further
https://bugs.webkit.org/attachment.cgi?id=68911&action=review

------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
The test still fails on the test bots for an unknown reason. I hope to get more
info from the output with this patch while still improving the test.

Using QCOMPARE() instead of QVERIFY() will output the return value so will help
identifying the issue. Adding the "hasFocus()" on each element will help
identifying if the element got the focus at all on the device.


More information about the webkit-reviews mailing list