[webkit-reviews] review denied: [Bug 46536] REGRESSION (r68260): Crash in PlatformCertificateInfo::~PlatformCertificateInfo when navigating away from Gmail : [Attachment 68899] Don't double-free CERT_CONTEXTs when copying PlatformCertificateInfos on Windows

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Adam Roben (aroben) <aroben at apple.com>'s
request for review:
Bug 46536: REGRESSION (r68260): Crash in
PlatformCertificateInfo::~PlatformCertificateInfo when navigating away from
Gmail
https://bugs.webkit.org/show_bug.cgi?id=46536

Attachment 68899: Don't double-free CERT_CONTEXTs when copying
PlatformCertificateInfos on Windows
https://bugs.webkit.org/attachment.cgi?id=68899&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68899&action=review

> WebKit2/Shared/win/PlatformCertificateInfo.cpp:77
> +PlatformCertificateInfo& PlatformCertificateInfo::operator=(const
PlatformCertificateInfo& other)
> +{
> +    if (m_certificateContext)
> +	   ::CertFreeCertificateContext(m_certificateContext);
> +    m_certificateContext =
::CertDuplicateCertificateContext(other.m_certificateContext);
> +    return *this;
> +}

We should try and handle the self-assignment case here.