[webkit-reviews] review granted: [Bug 45221] Adding support to pass multitouch events from Android browser to webkit : [Attachment 68764] Updated patch per Steve's comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 27 05:03:11 PDT 2010
Steve Block <steveblock at google.com> has granted Harry Wu
<mediadependent at gmail.com>'s request for review:
Bug 45221: Adding support to pass multitouch events from Android browser to
webkit
https://bugs.webkit.org/show_bug.cgi?id=45221
Attachment 68764: Updated patch per Steve's comments
https://bugs.webkit.org/attachment.cgi?id=68764&action=review
------- Additional Comments from Steve Block <steveblock at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68764&action=review
Are you a committer? If not, and you'd like a patch to be committed on your
behalf, be sure to set the cq? flag.
> LayoutTests/fast/events/touch/basic-multi-touch-events-limited.html:9
> + where one touch point is released while another is maintained.
It looks like you've edited this from the output of
WebKitTools/Scripts/make-script-test-wrappers? You shouldn't do this. Tests
that use the 'script-tests + TEMPLATE.html' approach should be written entirely
in the JS file. This sentence could be part of the description() text.
More information about the webkit-reviews
mailing list