[webkit-reviews] review granted: [Bug 45812] Filter builder should be able to follow the filter object dependencies : [Attachment 68896] Patch 2

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 45812: Filter builder should be able to follow the filter object
dependencies
https://bugs.webkit.org/show_bug.cgi?id=45812

Attachment 68896: Patch 2
https://bugs.webkit.org/attachment.cgi?id=68896&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68896&action=review

Great ptach! Please change the two issues above before landing. r=me.

> WebCore/svg/graphics/filters/SVGFilterBuilder.cpp:78
> +    int numberOfInputEffects = effect->inputEffects().size();

should be unsigned

> WebCore/svg/graphics/filters/SVGFilterBuilder.cpp:81
> +    for (int i = 0; i < numberOfInputEffects; ++i)

ditto.