[webkit-reviews] review granted: [Bug 45929] Support generating a FormData object based on the data in an existing <form> : [Attachment 68110] Proposed Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 45929: Support generating a FormData object based on the data in an
existing <form>
https://bugs.webkit.org/show_bug.cgi?id=45929

Attachment 68110: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=68110&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68110&action=review

Is this from some spec?

> WebCore/html/DOMFormData.cpp:50
> +    if (form)

Prefer early return.

> WebCore/html/DOMFormData.h:55
>      DOMFormData(const TextEncoding&);
> +    DOMFormData(HTMLFormElement*);

These need to be marked "explicit".