[webkit-reviews] review granted: [Bug 39136] sheriffbot can't roll out security patches : [Attachment 68336] Patch with unit test

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 39136: sheriffbot can't roll out security patches
https://bugs.webkit.org/show_bug.cgi?id=39136

Attachment 68336: Patch with unit test
https://bugs.webkit.org/attachment.cgi?id=68336&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68336&action=review

> WebKitTools/Scripts/webkitpy/tool/bot/sheriff.py:73
> +		   ScriptError(message="SheriffBot is not authorized to view
%s." % self._tool.bugs.bug_url_for_bug_id(e.bug_id()))
> +	       else:
> +		   ScriptError(message="Could not determine the corresponding
bug for r%s." % svn_revision)

Did you want to raise these errors?

> WebKitTools/Scripts/webkitpy/tool/commands/download.py:167
> +		       raise e

You just want to say "raise" without giving the exception again.  That will
make the stack trace better.

> WebKitTools/Scripts/webkitpy/tool/commands/download.py:183
> +		       raise e

ditto