[webkit-reviews] review granted: [Bug 46553] REGRESSION (r68289): Assertion failure in StringHasher::addCharacter() (ch != invalidCharacterValue) running websocket/tests/bad-sub-protocol-non-ascii.html : [Attachment 68815] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 46553: REGRESSION (r68289): Assertion failure in
StringHasher::addCharacter() (ch != invalidCharacterValue) running
websocket/tests/bad-sub-protocol-non-ascii.html
https://bugs.webkit.org/show_bug.cgi?id=46553

Attachment 68815: Patch
https://bugs.webkit.org/attachment.cgi?id=68815&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68815&action=review

I see.	We're just talking about FFFE.

> JavaScriptCore/ChangeLog:7
> +	   REGRESSION (r68289): Assertion failure in
StringHasher::addCharacter() (ch != invalidCharacterValue)
> +	   running websocket/tests/bad-sub-protocol-non-ascii.html
> +	   https://bugs.webkit.org/show_bug.cgi?id=46553

Thanks.  This bug was troubling me.

> JavaScriptCore/ChangeLog:9
> +	   Because we use StringHasher for binary data too, so the check for
invalid unicode input is wrong.

Why are we using StringHasher for binary data?	String is supposed to represent
a UTF16 string.