[webkit-reviews] review granted: [Bug 46571] [jsc] Document the op_strcat opcode : [Attachment 68836] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Sep 26 21:10:55 PDT 2010
Adam Barth <abarth at webkit.org> has granted Holger Freyther
<zecke at selfish.org>'s request for review:
Bug 46571: [jsc] Document the op_strcat opcode
https://bugs.webkit.org/show_bug.cgi?id=46571
Attachment 68836: Patch
https://bugs.webkit.org/attachment.cgi?id=68836&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68836&action=review
> JavaScriptCore/ChangeLog:7
> + Need a short description and bug URL (OOPS!)
You're supposed to fill out this part of the ChangeLog. :)
> JavaScriptCore/interpreter/Interpreter.cpp:4255
> + consurctor, and puts the result in register dst.
consurctor => constructor
More information about the webkit-reviews
mailing list