[webkit-reviews] review granted: [Bug 46580] [Mac][DRT] Implement LayoutTestController::nodesFromRect : [Attachment 68865] patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 26 16:50:23 PDT 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 46580: [Mac][DRT] Implement LayoutTestController::nodesFromRect
https://bugs.webkit.org/show_bug.cgi?id=46580

Attachment 68865: patch v2
https://bugs.webkit.org/attachment.cgi?id=68865&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68865&action=review

I'm not a master on the mac javascript stuff, but it seems quite sensible.

> WebKitTools/DumpRenderTree/LayoutTestController.cpp:527
> +    // Has mac implementation

Misses dot at the end. But what do you mean with this?


More information about the webkit-reviews mailing list