[webkit-reviews] review denied: [Bug 26978] valueOf called in wrong order in atan2 and date constructors. : [Attachment 68842] Fix for atan2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 25 22:08:35 PDT 2010


Oliver Hunt <oliver at apple.com> has denied Mark Hahnenberg
<mhahnenb at gmail.com>'s request for review:
Bug 26978: valueOf called in wrong order in atan2 and date constructors.
https://bugs.webkit.org/show_bug.cgi?id=26978

Attachment 68842: Fix for atan2
https://bugs.webkit.org/attachment.cgi?id=68842&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
code is good, but you need to make a changelog -- "prepare-Changelog --bug
26978" will get all the correct formatting done so you can just fill in the
details


More information about the webkit-reviews mailing list