[webkit-reviews] review granted: [Bug 45245] [Qt] fix uri/escaped-entity.html : [Attachment 66661] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <andreas.kling at nokia.com> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 45245: [Qt] fix uri/escaped-entity.html
https://bugs.webkit.org/show_bug.cgi?id=45245

Attachment 66661: Patch
https://bugs.webkit.org/attachment.cgi?id=66661&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=66661&action=review

> WebCore/platform/text/qt/TextCodecQt.cpp:137
> +    // FIXME: Until http://bugreports.qt.nokia.com/browse/QTBUG-13412 is
resolved we need to this ourselves

Note: It's unlikely that QTBUG-13412 will ever be implemented.

> WebCore/platform/text/qt/TextCodecQt.cpp:146
> +	 for (int pos = 0; pos < length; ++pos) {

Sign mismatch, pos should be size_t.

I've discussed this with Olivier Goffart and we feel it's Good Enough(tm).
Please fix the style before committing (tabs should be 4 spaces, not 2.)