[webkit-reviews] review denied: [Bug 43942] Textures and renderbuffers should be detached first before deletion if they are attached to framebuffers : [Attachment 67585] patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 43942: Textures and renderbuffers should be detached first before deletion
if they are attached to framebuffers
https://bugs.webkit.org/show_bug.cgi?id=43942

Attachment 67585: patch
https://bugs.webkit.org/attachment.cgi?id=67585&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=67585&action=review

I think the code looks generally good. r- for a documentation issue as well as
one potential code cleanup I'd like you to think about. Also, please check in
the new test to the Khronos conformance suite.

> WebCore/html/canvas/WebGLObject.h:66
>	   if (!m_attachmentCount && m_deleted)

The test of m_deleted seems to be no longer necessary since it's being tested
in deleteObjectImpl.

> WebCore/html/canvas/WebGLObject.h:73
>      virtual void deleteObjectImpl(Platform3DObject) = 0;

Please document that this may be called multiple times for the same object, and
that isDeleted() needs to be tested in implementations when deciding whether to
delete the OpenGL resource.