[webkit-reviews] review granted: [Bug 46504] FormatBlockCommand's modifyRange and doApply should be merged : [Attachment 68741] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 46504: FormatBlockCommand's modifyRange and doApply should be merged
https://bugs.webkit.org/show_bug.cgi?id=46504

Attachment 68741: Patch
https://bugs.webkit.org/attachment.cgi?id=68741&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68741&action=review

In general, this seems fine.  It looks like it reduces the amount of recursion
used, which is also good.

> WebCore/editing/FormatBlockCommand.cpp:71
> +    if (endingSelection().isCaret() || startOfParagraph(visibleStart) ==
startOfLastParagraph) {
> +	   doApplyForSingleParagraph();
>	   return;
> +    }

Can you comment on why you added the isCaret() check?  It seems like it's a new
condition.