[webkit-reviews] review denied: [Bug 46535] webkit does not build when PLUGIN_PROXY_FOR_VIDEO : [Attachment 68777] build fixes
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 24 16:01:51 PDT 2010
Eric Seidel <eric at webkit.org> has denied Joe Mason <jmason at rim.com>'s request
for review:
Bug 46535: webkit does not build when PLUGIN_PROXY_FOR_VIDEO
https://bugs.webkit.org/show_bug.cgi?id=46535
Attachment 68777: build fixes
https://bugs.webkit.org/attachment.cgi?id=68777&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68777&action=review
> WebCore/loader/FrameLoader.cpp:3531
> +#if ENABLE(PLUGIN_PROXY_FOR_VIDEO)
> +
> +void FrameLoader::hideMediaPlayerProxyPlugin(Widget* widget)
> +{
> + m_client->hideMediaPlayerProxyPlugin(widget);
> +}
> +
> +void FrameLoader::showMediaPlayerProxyPlugin(Widget* widget)
> +{
> + m_client->showMediaPlayerProxyPlugin(widget);
> +}
> +
> +#endif // ENABLE(PLUGIN_PROXY_FOR_VIDEO)
These methods do not belong on FrameLoader. Just talk directly to the client.
More information about the webkit-reviews
mailing list