[webkit-reviews] review requested: [Bug 46535] webkit does not build when PLUGIN_PROXY_FOR_VIDEO : [Attachment 68777] build fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 24 15:51:50 PDT 2010


Joe Mason <jmason at rim.com> has asked  for review:
Bug 46535: webkit does not build when PLUGIN_PROXY_FOR_VIDEO
https://bugs.webkit.org/show_bug.cgi?id=46535

Attachment 68777: build fixes
https://bugs.webkit.org/attachment.cgi?id=68777&action=review

------- Additional Comments from Joe Mason <jmason at rim.com>
The patches for these three bugs introduced a lot of build errors in code
that's wrapped in "if ENABLE(PLUGIN_PROXY_FOR_VIDEO)":

	https://bugs.webkit.org/show_bug.cgi?id=36681
	https://bugs.webkit.org/show_bug.cgi?id=42770
	https://bugs.webkit.org/show_bug.cgi?id=45058

The attached patch fixes them.

I'm not 100% sure that changing "url = src()" to "url = currentSrc()" is
correct, but I don't see anything else obvious to do here.


More information about the webkit-reviews mailing list