[webkit-reviews] review granted: [Bug 46529] Output X-Purpose header for prefetch requests : [Attachment 68773] patch to do this, with test

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Gavin Peters <gavinp at chromium.org>'s
request for review:
Bug 46529: Output X-Purpose header for prefetch requests
https://bugs.webkit.org/show_bug.cgi?id=46529

Attachment 68773: patch to do this, with test
https://bugs.webkit.org/attachment.cgi?id=68773&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68773&action=review

> LayoutTests/http/tests/misc/prefetch-purpose.html:11
> +    setTimeout("finishUp()",50);

This is racy, no?

Also, we should do this unconditionally in the load event handler.

> LayoutTests/http/tests/misc/resources/prefetch-purpose.php:6
> +    echo $_COOKIE['X-Purpose'];

Do we need to clear the cookie in this response?  Otherwise, this state will
leak into other tests.