[webkit-reviews] review denied: [Bug 46234] Add HRTFDatabaseLoader files : [Attachment 68315] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Chris Rogers
<crogers at google.com>'s request for review:
Bug 46234: Add HRTFDatabaseLoader files
https://bugs.webkit.org/show_bug.cgi?id=46234

Attachment 68315: Patch
https://bugs.webkit.org/attachment.cgi?id=68315&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68315&action=review

How is this class supposed to be used?	It seems that a user would first call
loadAsynchronously(), but then have nothing better to do but poll isLoaded()
until it returns true, which doesn't seem very useful.	Should this expose a
callback for users?

r- for the unsafe use of RefPtr across threads.

> WebCore/platform/audio/HRTFDatabaseLoader.cpp:76
> +	   m_hrtfDatabase = HRTFDatabase::createForSubject("Composite",
m_databaseSampleRate);

It is not safe to increment a reference on a RefCounted object from one thread
and then increment/decrement references from another thread.