[webkit-reviews] review requested: [Bug 44309] Hook up ANGLE with chromium --in-process-webgl port : [Attachment 68767] revised patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 24 15:15:29 PDT 2010


Zhenyao Mo <zmo at google.com> has asked  for review:
Bug 44309: Hook up ANGLE with chromium --in-process-webgl port
https://bugs.webkit.org/show_bug.cgi?id=44309

Attachment 68767: revised patch
https://bugs.webkit.org/attachment.cgi?id=68767&action=review

------- Additional Comments from Zhenyao Mo <zmo at google.com>
So I didn't use AngleWebKitBridge because the Angle under webkit is out-of-sync
again.	Besides, AngleWebKitBridge isn't very efficient and I feel optimizing
it should be a separate patch.

Per discussion with alokp at google, we don't call ShFinalize per canvas exit, but
per process exit, so I will add it to renderer exit code in a chromium patch. 
This patch alone should work because the angle resource will be released anyway
when the renderer process exits.


More information about the webkit-reviews mailing list