[webkit-reviews] review denied: [Bug 46412] [CHROMIUM] <canvas> clearRect() doesn't respect active clipping region, when --enable-accelerated-2d-canvas is on : [Attachment 68672] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 46412: [CHROMIUM] <canvas> clearRect() doesn't respect active clipping
region, when --enable-accelerated-2d-canvas is on
https://bugs.webkit.org/show_bug.cgi?id=46412

Attachment 68672: Patch
https://bugs.webkit.org/attachment.cgi?id=68672&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68672&action=review

> WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:351
> +    if (platformContext()->useGPU() &&
!platformContext()->canvasClipApplied()) {
>	   platformContext()->prepareForHardwareDraw();
>	   platformContext()->gpuCanvas()->clearRect(rect);
>	   return;
>      }
>  
> +    // Temporarily force the mode to "clear" to trigger a readback

I'd much prefer doing a syncSoftwareCanvas() here rather than depending on side
effects of the Xfer mode being set to do the readback.