[webkit-reviews] review granted: [Bug 37563] new-run-webkit-tests prints out nothing when build-dumprendertree fails : [Attachment 68662] Patch V1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 24 14:16:52 PDT 2010


Eric Seidel <eric at webkit.org> has granted Kenichi Ishibashi
<bashi at google.com>'s request for review:
Bug 37563: new-run-webkit-tests prints out nothing when build-dumprendertree
fails
https://bugs.webkit.org/show_bug.cgi?id=37563

Attachment 68662: Patch V1
https://bugs.webkit.org/attachment.cgi?id=68662&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68662&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py:87
> -	   return not self._executive.run_command([
> +	   exit_code = self._executive.run_command([

We don't really need to stash the exit_code in a local, but this is fine. :)


More information about the webkit-reviews mailing list