[webkit-reviews] review requested: [Bug 46066] SVG: Make SVGLength's stringToLengthType() stricter and faster : [Attachment 68733] Proposed patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 24 12:46:29 PDT 2010


Andreas Kling <andreas.kling at nokia.com> has asked  for review:
Bug 46066: SVG: Make SVGLength's stringToLengthType() stricter and faster
https://bugs.webkit.org/show_bug.cgi?id=46066

Attachment 68733: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=68733&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
Strictified SVGLength to only accept unit types immediately following the
numeric value, and with no whitespace after.
This behavior matches Firefox, but not IE9 or Opera.
IE9 accepts whitespace on both sides of the unit type.
Opera doesn't accept whitespace between the numeric value and the unit type,
but accepts it after the unit type.


More information about the webkit-reviews mailing list